Brian Jenney on LinkedIn: 4 little letters almost got me fired. LGTM. Looks good to me. Laterโ€ฆ | 106 comments (2024)

Brian Jenney

Engineering Manager and Owner of Parsity

  • Report this post

4 little letters almost got me fired.LGTM.Looks good to me.Later that day, I got a cryptic Slack message from the lead developer. "๐˜‰๐˜ณ๐˜ช๐˜ข๐˜ฏ, ๐˜ธ๐˜ฆ ๐˜ฏ๐˜ฆ๐˜ฆ๐˜ฅ ๐˜ต๐˜ฐ ๐˜ค๐˜ฉ๐˜ข๐˜ต"๐Ÿ˜ฌ ๐Ÿ’— ๐Ÿ“ˆTurns out the code I had barely reviewed blew up and was going to delay the feature from being released.Whoops.I was embarrassed and a little surprised - I mean, it wasnโ€™t like ๐—œ wrote the code.Either way, he was right. ๐—œ ๐—ต๐—ฎ๐—ฑ ๐—ณ๐—ฎ๐—ถ๐—น๐—ฒ๐—ฑ ๐˜๐—ผ ๐—ฑ๐—ผ ๐˜๐—ต๐—ฒ ๐—ฏ๐—ฎ๐—ฟ๐—ฒ ๐—บ๐—ถ๐—ป๐—ถ๐—บ๐˜‚๐—บ.I resolved to become the best damn code reviewer on the team that day.A year later, during my annual review, my manager told me that my peers were complimenting my reviews. I had prevented errors from slipping through and suggested solutions which led to more maintainable code.๐—œ ๐—ฏ๐—ฎ๐˜€๐—ถ๐—ฐ๐—ฎ๐—น๐—น๐˜† ๐—ท๐˜‚๐˜€๐˜ ๐—ฐ๐—ผ๐—ฝ๐—ถ๐—ฒ๐—ฑ ๐˜„๐—ต๐—ฎ๐˜ ๐—ผ๐˜‚๐—ฟ ๐—น๐—ฒ๐—ฎ๐—ฑ ๐—ฑ๐—ฒ๐˜ƒ๐—ฒ๐—น๐—ผ๐—ฝ๐—ฒ๐—ฟ ๐˜„๐—ฎ๐˜€ ๐—ฑ๐—ผ๐—ถ๐—ป๐—ด:1. Block off time in the morning to do the review2. Understand the work being done by reading the ticket associated with the PR3. Run code locally before looking at the code4. Read the code and ask questions or suggest improvements5. Use Loom or a screen share to discuss details or schedule a pair session if neededThis was a slow and often tedious process. ๐—œ ๐—ฐ๐—ฎ๐—ป ๐—ฎ๐—น๐—ฟ๐—ฒ๐—ฎ๐—ฑ๐˜† ๐˜€๐—ฒ๐—ฒ ๐—บ๐—ฎ๐—ป๐˜† ๐—ผ๐—ณ ๐˜†๐—ผ๐˜‚ ๐—ฟ๐—ผ๐—น๐—น๐—ถ๐—ป๐—ด ๐˜†๐—ผ๐˜‚๐—ฟ ๐—ฒ๐˜†๐—ฒ๐˜€.๐˜Š๐˜/๐˜Š๐˜‹!๐˜—๐˜ข๐˜ช๐˜ณ ๐˜ฑ๐˜ณ๐˜ฐ๐˜จ๐˜ณ๐˜ข๐˜ฎ!๐˜š๐˜ฎ๐˜ข๐˜ญ๐˜ญ ๐˜ค๐˜ฐ๐˜ฎ๐˜ฎ๐˜ช๐˜ต๐˜ด!Yes. Correct. Also - I still stand by this process.

1,720

106 Comments

Like Comment

Caleb Belk

Full-Stack Engineer

4d

  • Report this comment

Running code locally has been very useful in helping me understand how the changes relate to each other. The IDEs are way better at navigating the code than Azure Devops or Github PRs.Have you found that running locally has helped you catch bugs even while having thorough testing?

Like Reply

4Reactions 5Reactions

Dina Fine

MERN Full Stack Web Developer โœฎ ReactJS โœฎ NextJS โœฎ NodeJS โœฎ ExpressJS โœฎ MongoDB โœฎ Tailwind โœฎ Angular โœฎ US Navy Veteran โœฎ

4d

  • Report this comment

Oof.. that was a good lesson to learn! Slow and often tedious wins the race I guess. If I can share a Navy "Sea Story" โš“๏ธ ๐Ÿ‡บ๐Ÿ‡ธ here. I had an opposite experience where my Lead Petty Officer was notorious for being obsessively strict wanting his techs to go beyond perfection. ๐Ÿ™„ If I was 0.0000000000001 milliamps off, not good enough. I had to re-work all the circuit boards again... painful.One day the squadron said that some gear I worked on and that the Perfect Petty Officer checked my work out as good, came back to our avionics shop saying it wasn't repaired correctly. I KNEW that was impossible. Perfect Petty Officer and I went over to the squadron to inspect the gear, and, no surprise, we saw the pilot was in the wrong and did not have the gear installed properly. I'll never forget Perfect Petty Officer. ๐Ÿ˜Š

Like Reply

6Reactions 7Reactions

John Crickett

Helping you become a better software engineer through coding challenges that build real applications.

4d

  • Report this comment

Nicely illustrating why pair programming isn't 'slower' than doing the code review properly.It's just slower than phoning the code review in.Pair programming was code review dialled up to 11, so both are valid approaches. I'd prefer to pair program, it's more fun and often more productive.

Like Reply

29Reactions 30Reactions

Emily Jowers

Staff Software Engineer with Medely

4d

  • Report this comment

Good code reviewing is such a pain but itโ€™s good for all participants. You catch bugs, improve the codebase, and also have a better understanding of the codebase and feature. Small commits definitely help. If the PR is too large, I like to pair with the developer and walk through it. Goes a lot faster and I can ask questions as we go.

Like Reply

3Reactions 4Reactions

Pair programming has genuinely become my favorite thing. Great post Brian! These little (but impactful) processes can make a world of difference.

Like Reply

12Reactions 13Reactions

Uri Easter

MERN Stack & Front-End Developer

4d

  • Report this comment

Thank you for sharing this story. I have never actually done a code review before, but this a great insight on how to objectively review the functionality of code AND give helpful feedback to others. It does sound like a tedious process, but I think this will provide meaningful results. Saving this one for sure!

Like Reply

1Reaction 2Reactions

Miguel Mejia Leal

Senior Fullstack Developer

41m

  • Report this comment

This is nice, thanks a lotUnfortunately this is so dependent on the compay and team you are working with, I have team leads that are blockers forcing to merge code without a blink of the eye โ€ฆIn many teams you have persons with higher roles than yours and they can potentially ruin the application performance and lead into environments bugs just because they prefer โ€œdone than perfectโ€. No, it is not perfect, it is simply things well done, not mediocrity.If you happen to be part of a team were process, protocols, good pratices, are paramount and respected feel yourself lucky cause there are tons of projects out there full of micro management and old aged people that they prefer their ego over the truthly wise developerโ€™s decisions.

Like Reply

1Reaction

Aliaksandra Neviarouskaya

Software Engineering Team Lead - Orca Security

5h

  • Report this comment

IMO responsibility for how the solution works is on the person, who is implementing the solution, not the person who is doing a review.During the review, the person who is reviewing the code should make sure, that the code is concise and clear, and follows the team/company standards, running the code locally smells like a lack of trust in your peers. In case you need a screen sharing and pair session, code review is too late to have one. I believe developers should be encouraged to ask questions when they have any. Consult with the team and do an architectural review before starting the implementation. It increases the awareness of the task in the team and eliminates possible issues.Just to sum up: All code has bugs and there is nothing wrong with that. It can be improved, by increasing testing coverage, making the incident response smoother, and adjusting the processes of implementing and delivering a task. I feel sorry that you were almost fired for a bug and I suggest to look inside the processes in your team and do a short postmortem on what could have been done better.

Like Reply

1Reaction

Jamie McHugh

Lead Software Engineer at Made Tech

3d

  • Report this comment

This story feels over egged. Yes, care personally about the product, not just the code you write. But, being reprimanded for the impact of someone elses code hints at wider issues: primarily a lack CI/CD around feature branches coupled with loose or absent ATDD discipline. Boredom should result from writing automated tests, not from reviewing PRs. Feature branches should be spun up into a prod-like environment and have automated tests run against them. Hell, arguably if ATDD and CI/CD are embraced effectively, thereโ€™s an argument to be made for trunk-based development and continuous delivery.

Like Reply

7Reactions 8Reactions

Thomas Stringer

Staff Software Engineer / Site Reliability Engineer, Tech Lead | Linux | Kubernetes | Observability | Cloud

3d

  • Report this comment

While there is a lot of good info to take from this, it's important that people realize it's not normal or ok to feel like your job is in jeopardy if you approve code that ends up breaking something (or if you wrote that code, all the same). People make mistakes. The system failing to catch that is a fault in the system, not the people. Lessons are learned, but the system itself should improve so that this shouldn't happen again (e.g. write a test to uncover the issue so that there won't be a future regression).

Like Reply

23Reactions 24Reactions

See more comments

To view or add a comment, sign in

More Relevant Posts

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    I got laid off at the end of March. I just verbally accepted an offer yesterday.Here are some themes I noticed throughout my job searches, including this one:โ€ข ๐—ช๐—ผ๐—ฟ๐—ธ๐—ถ๐—ป๐—ด ๐˜„๐—ถ๐˜๐—ต ๐—ฟ๐—ฒ๐—ฐ๐—ฟ๐˜‚๐—ถ๐˜๐—ฒ๐—ฟ๐˜€ ๐—ถ๐˜€ ๐—ธ๐—ฒ๐˜†. All my interviews came from recruiters - basically none from cold applying.โ€ข ๐—Ÿ๐—ถ๐—ป๐—ธ๐—ฒ๐—ฑ๐—œ๐—ป ๐—ฒ๐—ฎ๐˜€๐˜† ๐—ฎ๐—ฝ๐—ฝ๐—น๐˜† ๐—ถ๐˜€ ๐—น๐—ถ๐—ธ๐—ฒ ๐—ฝ๐—น๐—ฎ๐˜†๐—ถ๐—ป๐—ด ๐˜๐—ต๐—ฒ ๐—น๐—ผ๐˜๐˜๐—ผ. It's unlikely to work but you can only win if you play.โ€ข ๐—œ๐—ป๐˜๐—ฒ๐—ฟ๐˜ƒ๐—ถ๐—ฒ๐˜„๐˜€ ๐˜„๐—ฒ๐—ฟ๐—ฒ ๐—ฎ ๐—บ๐—ถ๐˜… ๐—ผ๐—ณ ๐—ฐ๐—ผ๐—ฑ๐—ฒ ๐—ฐ๐—ต๐—ฎ๐—น๐—น๐—ฒ๐—ป๐—ด๐—ฒ๐˜€ ๐—ฎ๐—ป๐—ฑ ๐˜€๐˜๐—ผ๐—ฟ๐—ถ๐—ฒ๐˜€ to prove I knew my stuff. Very little DSA.๐˜›๐˜ฉ๐˜ฆ๐˜ด๐˜ฆ ๐˜ฒ๐˜ถ๐˜ฆ๐˜ด๐˜ต๐˜ช๐˜ฐ๐˜ฏ๐˜ด ๐˜ข๐˜ญ๐˜ธ๐˜ข๐˜บ๐˜ด ๐˜ค๐˜ฐ๐˜ฎ๐˜ฆ ๐˜ถ๐˜ฑ:- Tell me about an Interesting project you worked on and your role.- How would you handle conflict/deadlines?- Tell me about a process/improvement you led.โ€ข ๐—š๐—น๐—ฎ๐˜€๐˜€๐—ฑ๐—ผ๐—ผ๐—ฟ, ๐—ฅ๐—ฒ๐—ฑ๐—ฑ๐—ถ๐˜ ๐—ฎ๐—ป๐—ฑ ๐—•๐—น๐—ถ๐—ป๐—ฑ can really improve your chances of nailing an interview (๐˜ณ๐˜ฆ๐˜ด๐˜ฆ๐˜ข๐˜ณ๐˜ค๐˜ฉ ๐˜ฑ๐˜ณ๐˜ฆ๐˜ท๐˜ช๐˜ฐ๐˜ถ๐˜ด ๐˜ฒ๐˜ถ๐˜ฆ๐˜ด๐˜ต๐˜ช๐˜ฐ๐˜ฏ๐˜ด)โ€ข Writing down the ๐—ฐ๐—ผ๐—บ๐—ฝ๐—ฎ๐—ป๐˜† ๐˜ƒ๐—ฎ๐—น๐˜‚๐—ฒ๐˜€ ๐—ฎ๐—ป๐—ฑ ๐—ถ๐—ป๐˜€๐—ฒ๐—ฟ๐˜๐—ถ๐—ป๐—ด ๐˜๐—ต๐—ฒ๐—บ ๐—ถ๐—ป๐˜๐—ผ ๐˜๐—ต๐—ฒ ๐—ฐ๐—ผ๐—ป๐˜ƒ๐—ผ is helpfulโ€ข Doing ๐—บ๐—ผ๐—ฐ๐—ธ ๐—ถ๐—ป๐˜๐—ฒ๐—ฟ๐˜ƒ๐—ถ๐—ฒ๐˜„๐˜€ ๐—ต๐—ฒ๐—น๐—ฝ๐—ฒ๐—ฑ ๐—บ๐—ฒ ๐—ด๐—ฒ๐˜ ๐—ผ๐˜ƒ๐—ฒ๐—ฟ ๐—บ๐˜† ๐—ป๐—ฒ๐—ฟ๐˜ƒ๐—ฒ๐˜€ (๐˜ ๐˜ญ๐˜ช๐˜ฌ๐˜ฆ ๐˜—๐˜ณ๐˜ข๐˜ฎ๐˜ฑ[๐˜ฅ๐˜ฐ๐˜ต]๐˜ค๐˜ฐ๐˜ฎ - ๐˜ต๐˜ฉ๐˜ฆ๐˜บ ๐˜ด๐˜ฉ๐˜ฐ๐˜ถ๐˜ญ๐˜ฅ ๐˜ฉ๐˜ฐ๐˜ฏ๐˜ฆ๐˜ด๐˜ต๐˜ญ๐˜บ ๐˜ด๐˜ฑ๐˜ฐ๐˜ฏ๐˜ด๐˜ฐ๐˜ณ ๐˜ฎ๐˜ฆ ๐˜ข๐˜ต ๐˜ต๐˜ฉ๐˜ช๐˜ด ๐˜ฑ๐˜ฐ๐˜ช๐˜ฏ๐˜ต)Yes, I realize I have 25k+ followers and nearly a decade of experience. This makes my path different than yours. ๐— ๐˜† ๐˜€๐˜๐—ฟ๐—ฎ๐˜๐—ฒ๐—ด๐˜† ๐—ต๐—ฎ๐˜€๐—ป'๐˜ ๐—ฐ๐—ต๐—ฎ๐—ป๐—ด๐—ฒ๐—ฑ ๐—บ๐˜‚๐—ฐ๐—ต ๐—ผ๐˜ƒ๐—ฒ๐—ฟ ๐˜๐—ต๐—ฒ ๐˜†๐—ฒ๐—ฎ๐—ฟ๐˜€. The big difference is that my interviews now focus less on coding skills than they used to but I did crush a CodeSignal or 2 ๐Ÿ˜Ž.In case you're wondering - NO I was not part of any tech layoff. This was a marketing dept layoff and the reason I did not write about it is because I'm kinda sick of the layoff talk ๐Ÿ™„.Oh yeah - thank you to my previous corporate overlords. Learned a ton and met really great people. I can only pray that my efforts incrementally increased shareholder value ๐Ÿซก

    329

    36 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    I donโ€™t hate tutorials, I just don't like how most of you are using them. Youโ€™re probably making a lot of the same mistakes I did:- Passive watching- Falling down every rabbit hole- No practical applicationYou watch a 10 hour video, sit down to code and realize you have no f*ckin clue what to do.You hate to see it and Iโ€™ve been there.I use this method:- ๐—Ÿ๐—ฒ๐—ฎ๐—ฟ๐—ป ๐—ท๐˜‚๐˜€๐˜ ๐—ฒ๐—ป๐—ผ๐˜‚๐—ด๐—ต from your tutorial to begin writing some code- ๐—•๐˜‚๐—บ๐—ฏ๐—น๐—ฒ ๐˜†๐—ผ๐˜‚๐—ฟ ๐˜„๐—ฎ๐˜† ๐˜๐—ต๐—ฟ๐—ผ๐˜‚๐—ด๐—ต to get something you can interact with- Reach the limit of your technical depth and ๐—ด๐—ฒ๐˜ ๐˜€๐˜๐˜‚๐—ฐ๐—ธ- ๐—ฆ๐˜๐—ผ๐—ฝ ๐—ฐ๐—ผ๐—ฑ๐—ถ๐—ป๐—ด ๐—ฎ๐—ป๐—ฑ ๐—ฟ๐—ฒ-๐˜ƒ๐—ถ๐˜€๐—ถ๐˜ ๐˜๐—ต๐—ฒ ๐˜๐˜‚๐˜๐—ผ๐—ฟ๐—ถ๐—ฎ๐—น and build up some more knowledge for the next piece of your appRepeat.

    58

    12 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    ๐˜๐˜ฐ๐˜ธ ๐˜ฎ๐˜ฐ๐˜ด๐˜ต ๐˜ด๐˜ถ๐˜ค๐˜ค๐˜ฆ๐˜ด๐˜ด๐˜ง๐˜ถ๐˜ญ ๐˜ฃ๐˜ฐ๐˜ฐ๐˜ต๐˜ค๐˜ข๐˜ฎ๐˜ฑ ๐˜จ๐˜ณ๐˜ข๐˜ฅ๐˜ด ๐˜ฐ๐˜ฑ๐˜ฆ๐˜ณ๐˜ข๐˜ต๐˜ฆ:- Makes coding and learning a routine- Applies consistently and broadly- Has 1 or 2 complex side projects- Re-calibrates their approach when needed- Has faith that opportunity will present itself๐˜ž๐˜ฉ๐˜บ ๐˜ฎ๐˜ฐ๐˜ด๐˜ต ๐˜ฃ๐˜ฐ๐˜ฐ๐˜ต๐˜ค๐˜ข๐˜ฎ๐˜ฑ ๐˜จ๐˜ณ๐˜ข๐˜ฅ๐˜ด ๐˜ง๐˜ข๐˜ช๐˜ญ:- Applies to only junior roles- Tutorial- Tutorial- Tutorial- Relies on motivation instead of routine- Doesnโ€™t get hired in 3 months- ๐˜Ž๐˜ช๐˜ท๐˜ฆ๐˜ด ๐˜ถ๐˜ฑ

    64

    23 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    Here's how I'm actually doing my job search:๐—ฆ๐—ฒ๐—ฎ๐—ฟ๐—ฐ๐—ต๐—ถ๐—ป๐—ด:- 10% LinkedIn easy apply (you gotta play the lotto)- Hired a resume writer and updated my LI profile with keywords- Apply directly through the company site after finding them on Otta or Wellfound- DM recruiters and hiring managers for positions I really want๐—ฆ๐˜๐˜‚๐—ฑ๐˜†๐—ถ๐—ป๐—ด:- Use Pramp[dot]com for interview practice (LI hates links)- Read Alex Xu books on Sys Design- AlgoExpert for DSA practice or my own app (JavascriptProsApp[dot]com)- Create scripts for behavioral questions (why freestyle it?)๐—จ๐—ฝ-๐—ฆ๐—ธ๐—ถ๐—น๐—น๐—ถ๐—ป๐—ด:- Build sh*t using technology I should know better like Docker, TypeScript, AWS and a little Rust just in caseTLDR - a combination of mass applying, targeted applying and interview prep for non-FAANG roles. So far so good. It also doesn't hurt having 25k followers and 10 years experience so I'm not pretending that this flow will work for everyone.Hope that's helpful.

    97

    23 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    Unit tests are a waste of time.Instead of taking minutes to write a test you can just:- write your code- manually replicate all the scenarios you want to test- pray for the best and have your QA team ensure it all worksNow that it works, don't touch it! ๐Ÿ˜…When done correctly:- tests enable refactoring with confidence- confirm edge cases- document the ACTUAL functionality (I know your docs suck) ๐ŸคซOddly enough, most bootcamps skip any mention of unit testing even though most dev teams write loads of tests. Not Parsity tho ๐Ÿ˜‰Because you're probably smart and maybe even good looking - I have a repo for you to get your hands dirty with the basics of Jest and Unit Testing.๐˜š๐˜ถ๐˜ฑ๐˜ฆ๐˜ณ ๐˜ด๐˜ฆ๐˜ค๐˜ณ๐˜ฆ๐˜ต ๐˜ถ๐˜ฏ๐˜ช๐˜ต ๐˜ต๐˜ฆ๐˜ด๐˜ต๐˜ช๐˜ฏ๐˜จ ๐˜ณ๐˜ฆ๐˜ฑ๐˜ฐ ๐˜ง๐˜ฐ๐˜ณ ๐˜ฃ๐˜ฆ๐˜ต๐˜ต๐˜ฆ๐˜ณ ๐˜ต๐˜ฉ๐˜ข๐˜ฏ ๐˜ข๐˜ท๐˜ฆ๐˜ณ๐˜ข๐˜จ๐˜ฆ ๐˜ญ๐˜ฐ๐˜ฐ๐˜ฌ๐˜ช๐˜ฏ๐˜จ ๐˜ฅ๐˜ฆ๐˜ท๐˜ฆ๐˜ญ๐˜ฐ๐˜ฑ๐˜ฆ๐˜ณ๐˜ด ๐Ÿ‘‡https://lnkd.in/dh_bVgz9

    72

    16 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    ๐˜Š๐˜ฐ๐˜ฅ๐˜ฆ ๐˜ด๐˜ฉ๐˜ฐ๐˜ถ๐˜ญ๐˜ฅ ๐˜ข๐˜ญ๐˜ธ๐˜ข๐˜บ๐˜ด ๐˜ง๐˜ฐ๐˜ญ๐˜ญ๐˜ฐ๐˜ธ ๐˜‹๐˜™๐˜  ๐˜ฑ๐˜ณ๐˜ช๐˜ฏ๐˜ค๐˜ช๐˜ฑ๐˜ญ๐˜ฆ๐˜ด!Except, maybe your abstraction is more clever than useful in this case.๐˜›๐˜‹๐˜‹ ๐˜ฐ๐˜ณ ๐˜ฅ๐˜ช๐˜ฆ!Or you know, TaDD (test after development is done). Or, perhaps manual QA can be enough.๐˜›๐˜บ๐˜ฑ๐˜ฆ๐˜š๐˜ค๐˜ณ๐˜ช๐˜ฑ๐˜ต ๐˜ช๐˜ด ๐˜ต๐˜ฉ๐˜ฆ ๐˜ฐ๐˜ฏ๐˜ญ๐˜บ ๐˜ค๐˜ฉ๐˜ฐ๐˜ช๐˜ค๐˜ฆ ๐˜ง๐˜ฐ๐˜ณ ๐˜ด๐˜ฆ๐˜ณ๐˜ช๐˜ฐ๐˜ถ๐˜ด ๐˜‘๐˜š ๐˜ฅ๐˜ฆ๐˜ท๐˜ฆ๐˜ญ๐˜ฐ๐˜ฑ๐˜ฆ๐˜ณ๐˜ด!But maybe itโ€™s overkill for this simple UI app. Or just use JSDoc annotations.Be careful falling into dogmatic, knee-jerk responses when it comes to writing software. One thing Iโ€™ve learned is that there are exceptions to the rules we accept as coding law.***I sat down with your favorite TypeScript Wizard Ryan Talbert and learned what he really thinks about JavaScript, TypeScript and his wild origin story. You can check it out in the comments ๐Ÿ‘‡

    71

    18 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    He created a full stack app that worked pretty well. It even looked nice.But when I asked how it workedโ€ฆOof.๐—”๐—ป๐—ผ๐˜๐—ต๐—ฒ๐—ฟ ๐—ฐ๐—ฎ๐˜€๐—ฒ ๐—ผ๐—ณ ๐˜๐˜‚๐˜๐—ผ๐—ฟ๐—ถ๐—ฎ๐—น ๐—ฎ๐—ฏ๐˜‚๐˜€๐—ฒ. Too many people fall into the trap of looking at a tutorial, following along with the instructor and typing what they type. ๐—ง๐—ต๐—ฒ ๐—ฝ๐—ฎ๐˜†๐—ผ๐—ณ๐—ณ: a shiny new app. ๐—ง๐—ต๐—ฒ ๐—ฐ๐—ผ๐˜€๐˜: a false sense of masteryItโ€™s an enticing trap and it may even fool someone into hiring you. 90% of my side projects have never had users or been deployed. I made janky apps and sites to learn new concepts, frameworks and even join a startup as a mid-level developer in a completely new tech stack.Every side project doesnโ€™t need to be a masterpiece. Leverage them to learn what you wonโ€™t at work or what you would like to work on next.๐˜๐˜ง ๐˜บ๐˜ฐ๐˜ถ ๐˜ธ๐˜ข๐˜ฏ๐˜ต ๐˜ฎ๐˜บ ๐˜ด๐˜ต๐˜ฆ๐˜ฑ ๐˜ฃ๐˜บ ๐˜ด๐˜ต๐˜ฆ๐˜ฑ ๐˜จ๐˜ถ๐˜ช๐˜ฅ๐˜ฆ ๐˜ฐ๐˜ฏ ๐˜ค๐˜ณ๐˜ฆ๐˜ข๐˜ต๐˜ช๐˜ฏ๐˜จ ๐˜ข ๐˜ด๐˜ฐ๐˜ญ๐˜ช๐˜ฅ ๐˜ด๐˜ช๐˜ฅ๐˜ฆ ๐˜ฑ๐˜ณ๐˜ฐ๐˜ซ๐˜ฆ๐˜ค๐˜ต ๐˜บ๐˜ฐ๐˜ถ ๐˜ค๐˜ข๐˜ฏ ๐˜จ๐˜ณ๐˜ข๐˜ฃ ๐˜ช๐˜ต ๐˜ฉ๐˜ฆ๐˜ณ๐˜ฆ:https://lnkd.in/gEzeRC9F๐˜›๐˜ช๐˜ณ๐˜ฆ๐˜ฅ ๐˜ฐ๐˜ง ๐˜ต๐˜ถ๐˜ต๐˜ฐ๐˜ณ๐˜ช๐˜ข๐˜ญ๐˜ด? ๐˜Š๐˜ฉ๐˜ฆ๐˜ค๐˜ฌ ๐˜ต๐˜ฉ๐˜ช๐˜ด ๐˜ฐ๐˜ถ๐˜ต:https://lnkd.in/gpqEgqny

    106

    25 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    Youโ€™re having trouble coming up with solutions to problems as a software developer because youโ€™re re-inventing the wheel.As a junior developer, there are zero problems you will encounter that havenโ€™t been solved a dozen times over. There are tried and true approaches for that feature youโ€™re working on.But you donโ€™t know what you donโ€™t know.Hereโ€™s where Iโ€™d start:- ๐—น๐—ผ๐—ผ๐—ธ ๐˜‚๐—ฝ ๐—บ๐—ฒ๐˜๐—ฎ-๐˜€๐—ผ๐—ณ๐˜๐˜„๐—ฎ๐—ฟ๐—ฒ ๐—ฝ๐—ฎ๐˜๐˜๐—ฒ๐—ฟ๐—ป๐˜€ - the general design patterns that dominate the field- ๐—ณ๐—ฎ๐—บ๐—ถ๐—น๐—ถ๐—ฎ๐—ฟ๐—ถ๐˜‡๐—ฒ ๐˜†๐—ผ๐˜‚๐—ฟ๐˜€๐—ฒ๐—น๐—ณ ๐˜„๐—ถ๐˜๐—ต ๐—น๐—ฎ๐—ป๐—ด๐˜‚๐—ฎ๐—ด๐—ฒ-๐˜€๐—ฝ๐—ฒ๐—ฐ๐—ถ๐—ณ๐—ถ๐—ฐ ๐—ฝ๐—ฎ๐˜๐˜๐—ฒ๐—ฟ๐—ป๐˜€ - like the module pattern in JS- ๐—ฟ๐—ฒ๐—ฎ๐—ฑ ๐˜‚๐—ฝ ๐—ผ๐—ป ๐—ณ๐—ฟ๐—ฎ๐—บ๐—ฒ๐˜„๐—ผ๐—ฟ๐—ธ ๐—ฝ๐—ฎ๐˜๐˜๐—ฒ๐—ฟ๐—ป๐˜€ like presenter/container and HOCs for ReactJSYouโ€™ll begin to notice that much of the code you write either fits into a larger pattern or implements smaller patterns. Youโ€™ll be a more confident and efficient developer because of it.๐˜ž๐˜ฉ๐˜ข๐˜ต ๐˜ข๐˜ณ๐˜ฆ ๐˜ด๐˜ฐ๐˜ฎ๐˜ฆ ๐˜ค๐˜ฐ๐˜ฎ๐˜ฎ๐˜ฐ๐˜ฏ ๐˜ฑ๐˜ข๐˜ต๐˜ต๐˜ฆ๐˜ณ๐˜ฏ๐˜ด ๐˜บ๐˜ฐ๐˜ถ ๐˜ฉ๐˜ข๐˜ท๐˜ฆ ๐˜ฆ๐˜ฏ๐˜ค๐˜ฐ๐˜ถ๐˜ฏ๐˜ต๐˜ฆ๐˜ณ๐˜ฆ๐˜ฅ ๐˜ต๐˜ฉ๐˜ข๐˜ต ๐˜ธ๐˜ฐ๐˜ถ๐˜ญ๐˜ฅโ€™๐˜ท๐˜ฆ ๐˜ด๐˜ข๐˜ท๐˜ฆ๐˜ฅ ๐˜ต๐˜ฉ๐˜ฆ ๐˜บ๐˜ฐ๐˜ถ๐˜ฏ๐˜จ๐˜ฆ๐˜ณ ๐˜บ๐˜ฐ๐˜ถ?

    47

    2 Comments

    Like Comment

    To view or add a comment, sign in

  • Brian Jenney

    Engineering Manager and Owner of Parsity

    • Report this post

    A few months ago, I wrote about a developer who bombed a mock interview because he tried to use a ReactJS API during a vanilla JS challenge.I suggested he learn the fundamentals of JS before touching React.Now, Iโ€™m not so sure.๐—›๐—ผ๐˜„ ๐—บ๐˜‚๐—ฐ๐—ต ๐—๐—ฆ ๐—ฑ๐—ผ ๐˜†๐—ผ๐˜‚ ๐—ฟ๐—ฒ๐—ฎ๐—น๐—น๐˜† ๐—ป๐—ฒ๐—ฒ๐—ฑ ๐˜๐—ผ ๐—ธ๐—ป๐—ผ๐˜„ ๐—ป๐—ผ๐˜„๐—ฎ๐—ฑ๐—ฎ๐˜†๐˜€?Most roles for JS developers depend on a strong knowledge of the layer above JS. Companies want ReactJS, NextJS and Angular developers (the other 5 are looking for Vue developers ๐Ÿ˜‰).Is it still worth having a strong grasp on: - prototypal inheritance- closure- type coercion- scope/hoistingI realize you still need some clue about these concepts but perhaps much less than I previously thought.Is there anything so wrong with being a framework developer? It appears to be a lucrative career path. Genuinely curious.

    60

    42 Comments

    Like Comment

    To view or add a comment, sign in

Brian Jenney on LinkedIn: 4 little letters almost got me fired.LGTM.Looks good to me.Laterโ€ฆ | 106 comments (51)

Brian Jenney on LinkedIn: 4 little letters almost got me fired.LGTM.Looks good to me.Laterโ€ฆ | 106 comments (52)

  • 601 Posts
  • 16 Articles

View Profile

Follow

More from this author

  • What Separates Good Developers from Great Ones... That Has Nothing to Do With Writing Code Brian Jenney 3mo
  • Use This Pattern in Your Codebase or Itโ€™s Going to Cost You Brian Jenney 5mo
  • The 2nd Most Important Skill You Need as a Software Developer Brian Jenney 8mo

Explore topics

  • Sales
  • Marketing
  • Business Administration
  • HR Management
  • Content Management
  • Engineering
  • Soft Skills
  • See All
Brian Jenney on LinkedIn: 4 little letters almost got me fired.

LGTM.

Looks good to me.

Laterโ€ฆ | 106 comments (2024)
Top Articles
Latest Posts
Article information

Author: The Hon. Margery Christiansen

Last Updated:

Views: 6525

Rating: 5 / 5 (50 voted)

Reviews: 89% of readers found this page helpful

Author information

Name: The Hon. Margery Christiansen

Birthday: 2000-07-07

Address: 5050 Breitenberg Knoll, New Robert, MI 45409

Phone: +2556892639372

Job: Investor Mining Engineer

Hobby: Sketching, Cosplaying, Glassblowing, Genealogy, Crocheting, Archery, Skateboarding

Introduction: My name is The Hon. Margery Christiansen, I am a bright, adorable, precious, inexpensive, gorgeous, comfortable, happy person who loves writing and wants to share my knowledge and understanding with you.