Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
4 little letters almost got me fired.LGTM.Looks good to me.Later that day, I got a cryptic Slack message from the lead developer. "๐๐ณ๐ช๐ข๐ฏ, ๐ธ๐ฆ ๐ฏ๐ฆ๐ฆ๐ฅ ๐ต๐ฐ ๐ค๐ฉ๐ข๐ต"๐ฌ ๐ ๐Turns out the code I had barely reviewed blew up and was going to delay the feature from being released.Whoops.I was embarrassed and a little surprised - I mean, it wasnโt like ๐ wrote the code.Either way, he was right. ๐ ๐ต๐ฎ๐ฑ ๐ณ๐ฎ๐ถ๐น๐ฒ๐ฑ ๐๐ผ ๐ฑ๐ผ ๐๐ต๐ฒ ๐ฏ๐ฎ๐ฟ๐ฒ ๐บ๐ถ๐ป๐ถ๐บ๐๐บ.I resolved to become the best damn code reviewer on the team that day.A year later, during my annual review, my manager told me that my peers were complimenting my reviews. I had prevented errors from slipping through and suggested solutions which led to more maintainable code.๐ ๐ฏ๐ฎ๐๐ถ๐ฐ๐ฎ๐น๐น๐ ๐ท๐๐๐ ๐ฐ๐ผ๐ฝ๐ถ๐ฒ๐ฑ ๐๐ต๐ฎ๐ ๐ผ๐๐ฟ ๐น๐ฒ๐ฎ๐ฑ ๐ฑ๐ฒ๐๐ฒ๐น๐ผ๐ฝ๐ฒ๐ฟ ๐๐ฎ๐ ๐ฑ๐ผ๐ถ๐ป๐ด:1. Block off time in the morning to do the review2. Understand the work being done by reading the ticket associated with the PR3. Run code locally before looking at the code4. Read the code and ask questions or suggest improvements5. Use Loom or a screen share to discuss details or schedule a pair session if neededThis was a slow and often tedious process. ๐ ๐ฐ๐ฎ๐ป ๐ฎ๐น๐ฟ๐ฒ๐ฎ๐ฑ๐ ๐๐ฒ๐ฒ ๐บ๐ฎ๐ป๐ ๐ผ๐ณ ๐๐ผ๐ ๐ฟ๐ผ๐น๐น๐ถ๐ป๐ด ๐๐ผ๐๐ฟ ๐ฒ๐๐ฒ๐.๐๐/๐๐!๐๐ข๐ช๐ณ ๐ฑ๐ณ๐ฐ๐จ๐ณ๐ข๐ฎ!๐๐ฎ๐ข๐ญ๐ญ ๐ค๐ฐ๐ฎ๐ฎ๐ช๐ต๐ด!Yes. Correct. Also - I still stand by this process.
1,720
106 Comments
Caleb Belk
Full-Stack Engineer
4d
- Report this comment
Running code locally has been very useful in helping me understand how the changes relate to each other. The IDEs are way better at navigating the code than Azure Devops or Github PRs.Have you found that running locally has helped you catch bugs even while having thorough testing?
4Reactions 5Reactions
Dina Fine
MERN Full Stack Web Developer โฎ ReactJS โฎ NextJS โฎ NodeJS โฎ ExpressJS โฎ MongoDB โฎ Tailwind โฎ Angular โฎ US Navy Veteran โฎ
4d
- Report this comment
Oof.. that was a good lesson to learn! Slow and often tedious wins the race I guess. If I can share a Navy "Sea Story" โ๏ธ ๐บ๐ธ here. I had an opposite experience where my Lead Petty Officer was notorious for being obsessively strict wanting his techs to go beyond perfection. ๐ If I was 0.0000000000001 milliamps off, not good enough. I had to re-work all the circuit boards again... painful.One day the squadron said that some gear I worked on and that the Perfect Petty Officer checked my work out as good, came back to our avionics shop saying it wasn't repaired correctly. I KNEW that was impossible. Perfect Petty Officer and I went over to the squadron to inspect the gear, and, no surprise, we saw the pilot was in the wrong and did not have the gear installed properly. I'll never forget Perfect Petty Officer. ๐
6Reactions 7Reactions
John Crickett
Helping you become a better software engineer through coding challenges that build real applications.
4d
- Report this comment
Nicely illustrating why pair programming isn't 'slower' than doing the code review properly.It's just slower than phoning the code review in.Pair programming was code review dialled up to 11, so both are valid approaches. I'd prefer to pair program, it's more fun and often more productive.
29Reactions 30Reactions
Emily Jowers
Staff Software Engineer with Medely
4d
- Report this comment
Good code reviewing is such a pain but itโs good for all participants. You catch bugs, improve the codebase, and also have a better understanding of the codebase and feature. Small commits definitely help. If the PR is too large, I like to pair with the developer and walk through it. Goes a lot faster and I can ask questions as we go.
3Reactions 4Reactions
Brooke Sweedar
Software Engineer | Passionate about Technology, Innovation, and Building Meaningful Connections
4d
Pair programming has genuinely become my favorite thing. Great post Brian! These little (but impactful) processes can make a world of difference.
12Reactions 13Reactions
Uri Easter
MERN Stack & Front-End Developer
4d
- Report this comment
Thank you for sharing this story. I have never actually done a code review before, but this a great insight on how to objectively review the functionality of code AND give helpful feedback to others. It does sound like a tedious process, but I think this will provide meaningful results. Saving this one for sure!
1Reaction 2Reactions
Miguel Mejia Leal
Senior Fullstack Developer
41m
- Report this comment
This is nice, thanks a lotUnfortunately this is so dependent on the compay and team you are working with, I have team leads that are blockers forcing to merge code without a blink of the eye โฆIn many teams you have persons with higher roles than yours and they can potentially ruin the application performance and lead into environments bugs just because they prefer โdone than perfectโ. No, it is not perfect, it is simply things well done, not mediocrity.If you happen to be part of a team were process, protocols, good pratices, are paramount and respected feel yourself lucky cause there are tons of projects out there full of micro management and old aged people that they prefer their ego over the truthly wise developerโs decisions.
1Reaction
Aliaksandra Neviarouskaya
Software Engineering Team Lead - Orca Security
5h
- Report this comment
IMO responsibility for how the solution works is on the person, who is implementing the solution, not the person who is doing a review.During the review, the person who is reviewing the code should make sure, that the code is concise and clear, and follows the team/company standards, running the code locally smells like a lack of trust in your peers. In case you need a screen sharing and pair session, code review is too late to have one. I believe developers should be encouraged to ask questions when they have any. Consult with the team and do an architectural review before starting the implementation. It increases the awareness of the task in the team and eliminates possible issues.Just to sum up: All code has bugs and there is nothing wrong with that. It can be improved, by increasing testing coverage, making the incident response smoother, and adjusting the processes of implementing and delivering a task. I feel sorry that you were almost fired for a bug and I suggest to look inside the processes in your team and do a short postmortem on what could have been done better.
1Reaction
Jamie McHugh
Lead Software Engineer at Made Tech
3d
- Report this comment
This story feels over egged. Yes, care personally about the product, not just the code you write. But, being reprimanded for the impact of someone elses code hints at wider issues: primarily a lack CI/CD around feature branches coupled with loose or absent ATDD discipline. Boredom should result from writing automated tests, not from reviewing PRs. Feature branches should be spun up into a prod-like environment and have automated tests run against them. Hell, arguably if ATDD and CI/CD are embraced effectively, thereโs an argument to be made for trunk-based development and continuous delivery.
7Reactions 8Reactions
Thomas Stringer
Staff Software Engineer / Site Reliability Engineer, Tech Lead | Linux | Kubernetes | Observability | Cloud
3d
- Report this comment
While there is a lot of good info to take from this, it's important that people realize it's not normal or ok to feel like your job is in jeopardy if you approve code that ends up breaking something (or if you wrote that code, all the same). People make mistakes. The system failing to catch that is a fault in the system, not the people. Lessons are learned, but the system itself should improve so that this shouldn't happen again (e.g. write a test to uncover the issue so that there won't be a future regression).
23Reactions 24Reactions
To view or add a comment, sign in
More Relevant Posts
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
I got laid off at the end of March. I just verbally accepted an offer yesterday.Here are some themes I noticed throughout my job searches, including this one:โข ๐ช๐ผ๐ฟ๐ธ๐ถ๐ป๐ด ๐๐ถ๐๐ต ๐ฟ๐ฒ๐ฐ๐ฟ๐๐ถ๐๐ฒ๐ฟ๐ ๐ถ๐ ๐ธ๐ฒ๐. All my interviews came from recruiters - basically none from cold applying.โข ๐๐ถ๐ป๐ธ๐ฒ๐ฑ๐๐ป ๐ฒ๐ฎ๐๐ ๐ฎ๐ฝ๐ฝ๐น๐ ๐ถ๐ ๐น๐ถ๐ธ๐ฒ ๐ฝ๐น๐ฎ๐๐ถ๐ป๐ด ๐๐ต๐ฒ ๐น๐ผ๐๐๐ผ. It's unlikely to work but you can only win if you play.โข ๐๐ป๐๐ฒ๐ฟ๐๐ถ๐ฒ๐๐ ๐๐ฒ๐ฟ๐ฒ ๐ฎ ๐บ๐ถ๐ ๐ผ๐ณ ๐ฐ๐ผ๐ฑ๐ฒ ๐ฐ๐ต๐ฎ๐น๐น๐ฒ๐ป๐ด๐ฒ๐ ๐ฎ๐ป๐ฑ ๐๐๐ผ๐ฟ๐ถ๐ฒ๐ to prove I knew my stuff. Very little DSA.๐๐ฉ๐ฆ๐ด๐ฆ ๐ฒ๐ถ๐ฆ๐ด๐ต๐ช๐ฐ๐ฏ๐ด ๐ข๐ญ๐ธ๐ข๐บ๐ด ๐ค๐ฐ๐ฎ๐ฆ ๐ถ๐ฑ:- Tell me about an Interesting project you worked on and your role.- How would you handle conflict/deadlines?- Tell me about a process/improvement you led.โข ๐๐น๐ฎ๐๐๐ฑ๐ผ๐ผ๐ฟ, ๐ฅ๐ฒ๐ฑ๐ฑ๐ถ๐ ๐ฎ๐ป๐ฑ ๐๐น๐ถ๐ป๐ฑ can really improve your chances of nailing an interview (๐ณ๐ฆ๐ด๐ฆ๐ข๐ณ๐ค๐ฉ ๐ฑ๐ณ๐ฆ๐ท๐ช๐ฐ๐ถ๐ด ๐ฒ๐ถ๐ฆ๐ด๐ต๐ช๐ฐ๐ฏ๐ด)โข Writing down the ๐ฐ๐ผ๐บ๐ฝ๐ฎ๐ป๐ ๐๐ฎ๐น๐๐ฒ๐ ๐ฎ๐ป๐ฑ ๐ถ๐ป๐๐ฒ๐ฟ๐๐ถ๐ป๐ด ๐๐ต๐ฒ๐บ ๐ถ๐ป๐๐ผ ๐๐ต๐ฒ ๐ฐ๐ผ๐ป๐๐ผ is helpfulโข Doing ๐บ๐ผ๐ฐ๐ธ ๐ถ๐ป๐๐ฒ๐ฟ๐๐ถ๐ฒ๐๐ ๐ต๐ฒ๐น๐ฝ๐ฒ๐ฑ ๐บ๐ฒ ๐ด๐ฒ๐ ๐ผ๐๐ฒ๐ฟ ๐บ๐ ๐ป๐ฒ๐ฟ๐๐ฒ๐ (๐ ๐ญ๐ช๐ฌ๐ฆ ๐๐ณ๐ข๐ฎ๐ฑ[๐ฅ๐ฐ๐ต]๐ค๐ฐ๐ฎ - ๐ต๐ฉ๐ฆ๐บ ๐ด๐ฉ๐ฐ๐ถ๐ญ๐ฅ ๐ฉ๐ฐ๐ฏ๐ฆ๐ด๐ต๐ญ๐บ ๐ด๐ฑ๐ฐ๐ฏ๐ด๐ฐ๐ณ ๐ฎ๐ฆ ๐ข๐ต ๐ต๐ฉ๐ช๐ด ๐ฑ๐ฐ๐ช๐ฏ๐ต)Yes, I realize I have 25k+ followers and nearly a decade of experience. This makes my path different than yours. ๐ ๐ ๐๐๐ฟ๐ฎ๐๐ฒ๐ด๐ ๐ต๐ฎ๐๐ป'๐ ๐ฐ๐ต๐ฎ๐ป๐ด๐ฒ๐ฑ ๐บ๐๐ฐ๐ต ๐ผ๐๐ฒ๐ฟ ๐๐ต๐ฒ ๐๐ฒ๐ฎ๐ฟ๐. The big difference is that my interviews now focus less on coding skills than they used to but I did crush a CodeSignal or 2 ๐.In case you're wondering - NO I was not part of any tech layoff. This was a marketing dept layoff and the reason I did not write about it is because I'm kinda sick of the layoff talk ๐.Oh yeah - thank you to my previous corporate overlords. Learned a ton and met really great people. I can only pray that my efforts incrementally increased shareholder value ๐ซก
329
36 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
I donโt hate tutorials, I just don't like how most of you are using them. Youโre probably making a lot of the same mistakes I did:- Passive watching- Falling down every rabbit hole- No practical applicationYou watch a 10 hour video, sit down to code and realize you have no f*ckin clue what to do.You hate to see it and Iโve been there.I use this method:- ๐๐ฒ๐ฎ๐ฟ๐ป ๐ท๐๐๐ ๐ฒ๐ป๐ผ๐๐ด๐ต from your tutorial to begin writing some code- ๐๐๐บ๐ฏ๐น๐ฒ ๐๐ผ๐๐ฟ ๐๐ฎ๐ ๐๐ต๐ฟ๐ผ๐๐ด๐ต to get something you can interact with- Reach the limit of your technical depth and ๐ด๐ฒ๐ ๐๐๐๐ฐ๐ธ- ๐ฆ๐๐ผ๐ฝ ๐ฐ๐ผ๐ฑ๐ถ๐ป๐ด ๐ฎ๐ป๐ฑ ๐ฟ๐ฒ-๐๐ถ๐๐ถ๐ ๐๐ต๐ฒ ๐๐๐๐ผ๐ฟ๐ถ๐ฎ๐น and build up some more knowledge for the next piece of your appRepeat.
58
12 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
๐๐ฐ๐ธ ๐ฎ๐ฐ๐ด๐ต ๐ด๐ถ๐ค๐ค๐ฆ๐ด๐ด๐ง๐ถ๐ญ ๐ฃ๐ฐ๐ฐ๐ต๐ค๐ข๐ฎ๐ฑ ๐จ๐ณ๐ข๐ฅ๐ด ๐ฐ๐ฑ๐ฆ๐ณ๐ข๐ต๐ฆ:- Makes coding and learning a routine- Applies consistently and broadly- Has 1 or 2 complex side projects- Re-calibrates their approach when needed- Has faith that opportunity will present itself๐๐ฉ๐บ ๐ฎ๐ฐ๐ด๐ต ๐ฃ๐ฐ๐ฐ๐ต๐ค๐ข๐ฎ๐ฑ ๐จ๐ณ๐ข๐ฅ๐ด ๐ง๐ข๐ช๐ญ:- Applies to only junior roles- Tutorial- Tutorial- Tutorial- Relies on motivation instead of routine- Doesnโt get hired in 3 months- ๐๐ช๐ท๐ฆ๐ด ๐ถ๐ฑ
64
23 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
Here's how I'm actually doing my job search:๐ฆ๐ฒ๐ฎ๐ฟ๐ฐ๐ต๐ถ๐ป๐ด:- 10% LinkedIn easy apply (you gotta play the lotto)- Hired a resume writer and updated my LI profile with keywords- Apply directly through the company site after finding them on Otta or Wellfound- DM recruiters and hiring managers for positions I really want๐ฆ๐๐๐ฑ๐๐ถ๐ป๐ด:- Use Pramp[dot]com for interview practice (LI hates links)- Read Alex Xu books on Sys Design- AlgoExpert for DSA practice or my own app (JavascriptProsApp[dot]com)- Create scripts for behavioral questions (why freestyle it?)๐จ๐ฝ-๐ฆ๐ธ๐ถ๐น๐น๐ถ๐ป๐ด:- Build sh*t using technology I should know better like Docker, TypeScript, AWS and a little Rust just in caseTLDR - a combination of mass applying, targeted applying and interview prep for non-FAANG roles. So far so good. It also doesn't hurt having 25k followers and 10 years experience so I'm not pretending that this flow will work for everyone.Hope that's helpful.
97
23 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
Unit tests are a waste of time.Instead of taking minutes to write a test you can just:- write your code- manually replicate all the scenarios you want to test- pray for the best and have your QA team ensure it all worksNow that it works, don't touch it! ๐ When done correctly:- tests enable refactoring with confidence- confirm edge cases- document the ACTUAL functionality (I know your docs suck) ๐คซOddly enough, most bootcamps skip any mention of unit testing even though most dev teams write loads of tests. Not Parsity tho ๐Because you're probably smart and maybe even good looking - I have a repo for you to get your hands dirty with the basics of Jest and Unit Testing.๐๐ถ๐ฑ๐ฆ๐ณ ๐ด๐ฆ๐ค๐ณ๐ฆ๐ต ๐ถ๐ฏ๐ช๐ต ๐ต๐ฆ๐ด๐ต๐ช๐ฏ๐จ ๐ณ๐ฆ๐ฑ๐ฐ ๐ง๐ฐ๐ณ ๐ฃ๐ฆ๐ต๐ต๐ฆ๐ณ ๐ต๐ฉ๐ข๐ฏ ๐ข๐ท๐ฆ๐ณ๐ข๐จ๐ฆ ๐ญ๐ฐ๐ฐ๐ฌ๐ช๐ฏ๐จ ๐ฅ๐ฆ๐ท๐ฆ๐ญ๐ฐ๐ฑ๐ฆ๐ณ๐ด ๐https://lnkd.in/dh_bVgz9
72
16 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
๐๐ฐ๐ฅ๐ฆ ๐ด๐ฉ๐ฐ๐ถ๐ญ๐ฅ ๐ข๐ญ๐ธ๐ข๐บ๐ด ๐ง๐ฐ๐ญ๐ญ๐ฐ๐ธ ๐๐๐ ๐ฑ๐ณ๐ช๐ฏ๐ค๐ช๐ฑ๐ญ๐ฆ๐ด!Except, maybe your abstraction is more clever than useful in this case.๐๐๐ ๐ฐ๐ณ ๐ฅ๐ช๐ฆ!Or you know, TaDD (test after development is done). Or, perhaps manual QA can be enough.๐๐บ๐ฑ๐ฆ๐๐ค๐ณ๐ช๐ฑ๐ต ๐ช๐ด ๐ต๐ฉ๐ฆ ๐ฐ๐ฏ๐ญ๐บ ๐ค๐ฉ๐ฐ๐ช๐ค๐ฆ ๐ง๐ฐ๐ณ ๐ด๐ฆ๐ณ๐ช๐ฐ๐ถ๐ด ๐๐ ๐ฅ๐ฆ๐ท๐ฆ๐ญ๐ฐ๐ฑ๐ฆ๐ณ๐ด!But maybe itโs overkill for this simple UI app. Or just use JSDoc annotations.Be careful falling into dogmatic, knee-jerk responses when it comes to writing software. One thing Iโve learned is that there are exceptions to the rules we accept as coding law.***I sat down with your favorite TypeScript Wizard Ryan Talbert and learned what he really thinks about JavaScript, TypeScript and his wild origin story. You can check it out in the comments ๐
71
18 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
He created a full stack app that worked pretty well. It even looked nice.But when I asked how it workedโฆOof.๐๐ป๐ผ๐๐ต๐ฒ๐ฟ ๐ฐ๐ฎ๐๐ฒ ๐ผ๐ณ ๐๐๐๐ผ๐ฟ๐ถ๐ฎ๐น ๐ฎ๐ฏ๐๐๐ฒ. Too many people fall into the trap of looking at a tutorial, following along with the instructor and typing what they type. ๐ง๐ต๐ฒ ๐ฝ๐ฎ๐๐ผ๐ณ๐ณ: a shiny new app. ๐ง๐ต๐ฒ ๐ฐ๐ผ๐๐: a false sense of masteryItโs an enticing trap and it may even fool someone into hiring you. 90% of my side projects have never had users or been deployed. I made janky apps and sites to learn new concepts, frameworks and even join a startup as a mid-level developer in a completely new tech stack.Every side project doesnโt need to be a masterpiece. Leverage them to learn what you wonโt at work or what you would like to work on next.๐๐ง ๐บ๐ฐ๐ถ ๐ธ๐ข๐ฏ๐ต ๐ฎ๐บ ๐ด๐ต๐ฆ๐ฑ ๐ฃ๐บ ๐ด๐ต๐ฆ๐ฑ ๐จ๐ถ๐ช๐ฅ๐ฆ ๐ฐ๐ฏ ๐ค๐ณ๐ฆ๐ข๐ต๐ช๐ฏ๐จ ๐ข ๐ด๐ฐ๐ญ๐ช๐ฅ ๐ด๐ช๐ฅ๐ฆ ๐ฑ๐ณ๐ฐ๐ซ๐ฆ๐ค๐ต ๐บ๐ฐ๐ถ ๐ค๐ข๐ฏ ๐จ๐ณ๐ข๐ฃ ๐ช๐ต ๐ฉ๐ฆ๐ณ๐ฆ:https://lnkd.in/gEzeRC9F๐๐ช๐ณ๐ฆ๐ฅ ๐ฐ๐ง ๐ต๐ถ๐ต๐ฐ๐ณ๐ช๐ข๐ญ๐ด? ๐๐ฉ๐ฆ๐ค๐ฌ ๐ต๐ฉ๐ช๐ด ๐ฐ๐ถ๐ต:https://lnkd.in/gpqEgqny
106
25 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
Youโre having trouble coming up with solutions to problems as a software developer because youโre re-inventing the wheel.As a junior developer, there are zero problems you will encounter that havenโt been solved a dozen times over. There are tried and true approaches for that feature youโre working on.But you donโt know what you donโt know.Hereโs where Iโd start:- ๐น๐ผ๐ผ๐ธ ๐๐ฝ ๐บ๐ฒ๐๐ฎ-๐๐ผ๐ณ๐๐๐ฎ๐ฟ๐ฒ ๐ฝ๐ฎ๐๐๐ฒ๐ฟ๐ป๐ - the general design patterns that dominate the field- ๐ณ๐ฎ๐บ๐ถ๐น๐ถ๐ฎ๐ฟ๐ถ๐๐ฒ ๐๐ผ๐๐ฟ๐๐ฒ๐น๐ณ ๐๐ถ๐๐ต ๐น๐ฎ๐ป๐ด๐๐ฎ๐ด๐ฒ-๐๐ฝ๐ฒ๐ฐ๐ถ๐ณ๐ถ๐ฐ ๐ฝ๐ฎ๐๐๐ฒ๐ฟ๐ป๐ - like the module pattern in JS- ๐ฟ๐ฒ๐ฎ๐ฑ ๐๐ฝ ๐ผ๐ป ๐ณ๐ฟ๐ฎ๐บ๐ฒ๐๐ผ๐ฟ๐ธ ๐ฝ๐ฎ๐๐๐ฒ๐ฟ๐ป๐ like presenter/container and HOCs for ReactJSYouโll begin to notice that much of the code you write either fits into a larger pattern or implements smaller patterns. Youโll be a more confident and efficient developer because of it.๐๐ฉ๐ข๐ต ๐ข๐ณ๐ฆ ๐ด๐ฐ๐ฎ๐ฆ ๐ค๐ฐ๐ฎ๐ฎ๐ฐ๐ฏ ๐ฑ๐ข๐ต๐ต๐ฆ๐ณ๐ฏ๐ด ๐บ๐ฐ๐ถ ๐ฉ๐ข๐ท๐ฆ ๐ฆ๐ฏ๐ค๐ฐ๐ถ๐ฏ๐ต๐ฆ๐ณ๐ฆ๐ฅ ๐ต๐ฉ๐ข๐ต ๐ธ๐ฐ๐ถ๐ญ๐ฅโ๐ท๐ฆ ๐ด๐ข๐ท๐ฆ๐ฅ ๐ต๐ฉ๐ฆ ๐บ๐ฐ๐ถ๐ฏ๐จ๐ฆ๐ณ ๐บ๐ฐ๐ถ?
47
2 Comments
Like CommentTo view or add a comment, sign in
-
Brian Jenney
Engineering Manager and Owner of Parsity
- Report this post
A few months ago, I wrote about a developer who bombed a mock interview because he tried to use a ReactJS API during a vanilla JS challenge.I suggested he learn the fundamentals of JS before touching React.Now, Iโm not so sure.๐๐ผ๐ ๐บ๐๐ฐ๐ต ๐๐ฆ ๐ฑ๐ผ ๐๐ผ๐ ๐ฟ๐ฒ๐ฎ๐น๐น๐ ๐ป๐ฒ๐ฒ๐ฑ ๐๐ผ ๐ธ๐ป๐ผ๐ ๐ป๐ผ๐๐ฎ๐ฑ๐ฎ๐๐?Most roles for JS developers depend on a strong knowledge of the layer above JS. Companies want ReactJS, NextJS and Angular developers (the other 5 are looking for Vue developers ๐).Is it still worth having a strong grasp on: - prototypal inheritance- closure- type coercion- scope/hoistingI realize you still need some clue about these concepts but perhaps much less than I previously thought.Is there anything so wrong with being a framework developer? It appears to be a lucrative career path. Genuinely curious.
60
42 Comments
Like CommentTo view or add a comment, sign in
- 601 Posts
- 16 Articles
View Profile
FollowMore from this author
- What Separates Good Developers from Great Ones... That Has Nothing to Do With Writing Code Brian Jenney 3mo
- Use This Pattern in Your Codebase or Itโs Going to Cost You Brian Jenney 5mo
- The 2nd Most Important Skill You Need as a Software Developer Brian Jenney 8mo
Explore topics
- Sales
- Marketing
- Business Administration
- HR Management
- Content Management
- Engineering
- Soft Skills
- See All